Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added “DEVELOPER_ID_APPLICATION_G2” to certificate enums #266

Merged

Conversation

Workshed
Copy link
Contributor

@Workshed Workshed commented Apr 1, 2024

This means that when the code is generated we cover cases which Apple is returning but are not published in their OpenAPI spec as yet. This will resolve issue #252

@Workshed Workshed requested a review from AvdLee as a code owner April 1, 2024 18:28
@Workshed
Copy link
Contributor Author

Workshed commented Apr 2, 2024

I've submitted FB13704959 which duplicates your issue @MortenGregersen

@SwiftLeeBot
Copy link
Collaborator

Warnings
⚠️ 'Prices' is deprecated: Deprecated
⚠️ 'AvailableTerritories' is deprecated: Deprecated
⚠️ 'InAppPurchases' is deprecated: Deprecated
⚠️ 'Prices' is deprecated: Deprecated
⚠️ 'AvailableTerritories' is deprecated: Deprecated
⚠️ 'InAppPurchases' is deprecated: Deprecated
⚠️ 'Builds' is deprecated: Deprecated
⚠️ 'Builds' is deprecated: Deprecated
⚠️ 'AppPreOrder' is deprecated: Deprecated
⚠️ 'AppPrice' is deprecated: Deprecated
⚠️ 'InAppPurchase' is deprecated: Deprecated
⚠️ 'GameCenterEnabledVersion' is deprecated: Deprecated
⚠️ 'AgeRatingDeclaration' is deprecated: Deprecated
⚠️ 'AgeRatingDeclaration' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'AppStoreVersionSubmission' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'AppStoreVersionSubmission' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'Prices' is deprecated: Deprecated
⚠️ 'AvailableTerritories' is deprecated: Deprecated
⚠️ 'Prices' is deprecated: Deprecated
⚠️ 'AvailableTerritories' is deprecated: Deprecated
⚠️ 'AppPreOrder' is deprecated: Deprecated
⚠️ 'AppPrice' is deprecated: Deprecated
⚠️ 'InAppPurchase' is deprecated: Deprecated
⚠️ 'GameCenterEnabledVersion' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'Builds' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'AppStoreVersionSubmission' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'AppStoreVersionSubmission' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'Prices' is deprecated: Deprecated
⚠️ 'AvailableTerritories' is deprecated: Deprecated
⚠️ 'AppPreOrder' is deprecated: Deprecated
⚠️ 'AppPrice' is deprecated: Deprecated
⚠️ 'InAppPurchase' is deprecated: Deprecated
⚠️ 'GameCenterEnabledVersion' is deprecated: Deprecated
⚠️ 'Prices' is deprecated: Deprecated
⚠️ 'AvailableTerritories' is deprecated: Deprecated
⚠️ 'InAppPurchases' is deprecated: Deprecated
⚠️ 'AgeRatingDeclaration' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'AppStoreVersionExperiment' is deprecated: Deprecated
⚠️ 'AppPreOrder' is deprecated: Deprecated
⚠️ 'AppPrice' is deprecated: Deprecated
⚠️ 'InAppPurchase' is deprecated: Deprecated
⚠️ 'GameCenterEnabledVersion' is deprecated: Deprecated
Messages
📖 AppStoreConnect-Swift-SDK-Tests: Executed 17 tests (0 failed, 0 retried, 0 skipped) in 0.151 seconds
📖

View more details on Bitrise

Code Coverage Report

Name Coverage

SwiftLint found issues

Severity File Reason
Error PathsV1Certificates.swift:66 Line should be 160 characters or less; currently it has 260 characters (line_length)
Warning PathsV1Certificates.swift:8 An 'instance_property' should not be placed amongst the type content(s) 'subtype' (type_contents_order)

Generated by 🚫 Danger Swift against 5e71eda

Copy link
Owner

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting and making this contribution!

@AvdLee AvdLee merged commit cf24434 into AvdLee:master Apr 9, 2024
2 checks passed
@Workshed
Copy link
Contributor Author

Apple's response to the feedback:

Thank you for your message. Upon further review, we require additional files to help us investigate your feedback. Please reproduce the issue, provide a screen recording, and use Feedback Assistant to gather the requested file.

We appreciate your feedback and looking forward to hear from you.

@Workshed Workshed deleted the feature/add-missing-certificate-type branch April 13, 2024 07:15
@Workshed
Copy link
Contributor Author

Workshed commented May 7, 2024

Absolute waste of time raising this issue with Apple, their response is Resolution:Investigation complete - Unable to diagnose with current information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants