-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerated code for App Store Connect API 2.2 changes #220
Regenerated code for App Store Connect API 2.2 changes #220
Conversation
Also, there are sometimes more information for the error in the property |
There may well be, I've not found an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, this is a very welcome change!
Code Coverage Report
SwiftLint found issues
Generated by 🚫 Danger Swift against 9316abe |
@Workshed could you have a look at the tests? 🙏 |
@AvdLee I've added a fix for the failing test. Is Bitrise triggered manually by yourself? |
Hilariously API 2.3 was released last night |
The latest version of the OpenAPI schema is named 2.2 so the filenames have been updated in the project to match.
Tweaked the README to add instructions for the jq dependency.
What led me down the path of updating the schema is that the error from /v1/inAppPurchaseSubmissions can't be decoded in
RequestExecutor
. The lineself.errorResponse = try? APIProvider.jsonDecoder.decode(ErrorResponse.self, from: data)
always results innil
. This was due to adetail
field not being present in theErrorResponse
generated object. Unfortunately even the latest schema claims this field will always be present (it's really not), so for this PR I've manually removed it from the required elements inapp_store_connect_api_2.2_openapi.json
. Obviously this manual wrangling of the schema is not ideal but I imagine we'd rather have the error messages returned than not.