Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check daily for changes in published ASC API #201

Merged
merged 14 commits into from
Aug 25, 2022
Merged

Check daily for changes in published ASC API #201

merged 14 commits into from
Aug 25, 2022

Conversation

marcprux
Copy link
Contributor

This PR adds a workflow that will run daily and compare the contents of the currently-published ASC API spec (from https://developer.apple.com/sample-code/app-store-connect/app-store-connect-openapi-specification.zip) with the current contents of the HEAD branch. Any diffs will result in a workflow failure and notification, which will need to be address by manually updating the spec and re-generating the API (at least for now).

See discussion at: #197 (comment)

Note that the initial run will fail due to whitespace differences, which is a side-effect of using jq to fix the missing enum case (also mentioned in #197).

@SwiftLeeBot
Copy link
Collaborator

Warnings
⚠️ 'AppStoreVersionSubmission' is deprecated: Deprecated
⚠️ 'AppStoreVersionSubmission' is deprecated: Deprecated
⚠️ 'AppStoreVersionSubmission' is deprecated: Deprecated
⚠️ 'AppStoreVersionSubmission' is deprecated: Deprecated
⚠️ 'AgeRatingDeclaration' is deprecated: Deprecated
⚠️ 'AgeRatingDeclaration' is deprecated: Deprecated
⚠️ 'AgeRatingDeclaration' is deprecated: Deprecated
⚠️ 'AppPricePoint' is deprecated: Deprecated
⚠️ 'AppPricePoint' is deprecated: Deprecated
⚠️ 'AppPricePoint' is deprecated: Deprecated
⚠️ 'AppPricePoint' is deprecated: Deprecated
⚠️ 'AppPricePoint' is deprecated: Deprecated
⚠️ 'AppPricePoint' is deprecated: Deprecated
⚠️ 'PricePoints' is deprecated: Deprecated
⚠️ 'PricePoints' is deprecated: Deprecated
⚠️ 'PricePoints' is deprecated: Deprecated
⚠️ 'InAppPurchases' is deprecated: Deprecated
⚠️ 'InAppPurchases' is deprecated: Deprecated
⚠️ 'InAppPurchases' is deprecated: Deprecated
Messages
📖

View more details on Bitrise

📖 AppStoreConnect-Swift-SDK-Tests: Executed 9 tests (0 failed, 0 retried, 0 skipped) in 0.107 seconds

Code Coverage Report

Name Coverage

Generated by 🚫 Danger Swift against 8e778f3

Copy link
Owner

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start! Let's use and learn along the way 🚀

@AvdLee AvdLee merged commit 39241b4 into AvdLee:master Aug 25, 2022
@MortenGregersen
Copy link
Contributor

If you need some inspiration on how to create pull requests when the spec has changed, you can take a look at the script made for Bagbutik.

@SwiftLeeBot
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 2.3.0 🚀

Generated by GitBuddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants