Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional certficate types #105

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

orj
Copy link
Contributor

@orj orj commented Jun 3, 2020

Resolves #104

Real world testing proves that there are more "certificate types" than documented.

@orj orj requested a review from AvdLee as a code owner June 3, 2020 07:24
@SwiftLeeBot
Copy link
Collaborator

Messages
📖

View more details on Bitrise

Generated by 🚫 Danger Swift against 0b9a6a1

Copy link
Owner

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hoping for better documentation after WWDC 2020! Thanks for this 🙂

@AvdLee AvdLee merged commit 1d1887c into AvdLee:master Jun 4, 2020
@SwiftLeeBot
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 1.1.2 🚀

Generated by GitBuddy

DechengMa added a commit to ittybittyapps/appstoreconnect-swift-sdk that referenced this pull request Jun 11, 2020
Add additional certficate types (AvdLee#105)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List/Read Certificates fails to parse response.
3 participants