Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TP-687: WIP on using unicast when running tests with gs-test #132

Merged
merged 1 commit into from
May 18, 2022
Merged

TP-687: WIP on using unicast when running tests with gs-test #132

merged 1 commit into from
May 18, 2022

Conversation

pativa
Copy link
Contributor

@pativa pativa commented May 18, 2022

Use updated gs-test module that uses unicast instead of multicast.

Also, tests are using ZooKeeper based leader selection instead of LUS based.

Bjornelmers
Bjornelmers approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@Bjornelmers Bjornelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

ath0s
ath0s approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@ath0s ath0s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pativa pativa merged commit 1f29c1e into main May 18, 2022
@pativa pativa deleted the tp-687-use-gs-test-unicast branch May 18, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bjornelmers Bjornelmers Bjornelmers approved these changes

@ath0s ath0s ath0s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pativa @ath0s @Bjornelmers