feat: When in DevTools using Copy Selector replace Clr Namespace with xmlns #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
reviewed
Apr 18, 2024
maxkatz6
reviewed
Apr 30, 2024
|
|
||
| namespace Avalonia.Ide.CompletionEngine.Parsing; | ||
|
|
||
| public record struct DevToolsSelectorInfo(Range ElementType, Range Namespace, Range AssemblyName = default) |
There was a problem hiding this comment.
It could a ref struct with Span/Memory instead as well. Since it's not stored anywhere outside of the same stack.
But range might be fine too, just adds too much of polyfills.
maxkatz6
reviewed
Apr 30, 2024
| @@ -0,0 +1,39 @@ | |||
| namespace System.Runtime.CompilerServices | |||
| { | |||
| internal static class RuntimeHelpers | |||
There was a problem hiding this comment.
These RuntimeHelpers are defined twice in the PR.
maxkatz6
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speed up writing a Style Selector.
When Copy Selector using [DevTools] treeview context menu, it put text like this in clipboard:
FluentAvalonia.UI.Controls.NavigationView#NavView.Store /template/ Avalonia.Controls.ScrollViewer#FooterItemsScrollViewerDependent on AvaloniaUI/Avalonia#14603
Fixes #448