Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avalonia.Ide.CompletionEngine: nullable, trimming, STJ, code format #294

Merged
merged 5 commits into from
Feb 9, 2023

Conversation

maxkatz6
Copy link
Member

@maxkatz6 maxkatz6 commented Feb 8, 2023

Updated Avalonia.Ide.CompletionEngine projects to be up to date with common style rules and nullability props same as main repository. Specifically:

  • Nullable enabled
  • net6 is an additional target (not really used, but can be used if we upload this package to the nuget)
  • Records are used where makes sense
  • Multiple potential issue are fixed with nullables
  • At least one bug with IImage using code completion from IBitmap was fixed (copy paste error)
  • System.Text.Json instead of Newtonsoft. Not really a beneficial change, but there is no reason to bring old dependency here.
  • Copy paste editor config from main repo and formatted code
  • File scope namespaces (technically, it makes git blame harder to use, but in fact all of these files were copy pasted from another repository, so there is no much difference).

@maxkatz6 maxkatz6 enabled auto-merge February 8, 2023 07:57
@maxkatz6 maxkatz6 merged commit fada721 into master Feb 9, 2023
@maxkatz6 maxkatz6 deleted the nullable branch February 9, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant