Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ARM only] Fix incorrect parameters passed to the CreateDrawingSurface method #9342

Merged
merged 4 commits into from
Nov 3, 2022
Merged

[ARM only] Fix incorrect parameters passed to the CreateDrawingSurface method #9342

merged 4 commits into from
Nov 3, 2022

Conversation

maxkatz6
Copy link
Member

@maxkatz6 maxkatz6 commented Nov 2, 2022 •
edited
Loading

As @olifink noticed, we use a wrong method's parameter type.

What does the pull request do?

  1. Uses a CreateDrawingSurface2 method that accepts integer SIZE struct.
  2. Fixes old CreateDrawingSurface usage by changing type to a correct one (SIZE_F).

Fixed issues

Fixes #8776

@maxkatz6 maxkatz6 mentioned this pull request Nov 2, 2022
Closed
@maxkatz6 maxkatz6 requested a review from a team November 2, 2022 18:54
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0025667-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

@kekekeks kekekeks enabled auto-merge (squash) November 3, 2022 05:38
@kekekeks kekekeks merged commit 4670536 into master Nov 3, 2022
@kekekeks kekekeks deleted the use-correct-com-method branch November 3, 2022 05:52
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0025688-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

@olifink olifink mentioned this pull request Nov 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kekekeks kekekeks kekekeks approved these changes

@ThadHouse ThadHouse ThadHouse approved these changes

Assignees
No one assigned
Labels
bug os-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when running on Windows 11 on ARM
4 participants
@maxkatz6 @avaloniaui-team @kekekeks @ThadHouse