Replace old shared project with real one - Avalonia.PlatformSupport #7347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
force-pushed
the
platform-support-project
branch
from
32c0b96 to
f451b7c
Compare
Merged
maxkatz6
force-pushed
the
platform-support-project
branch
4 times, most recently
from
c617deb to
2b0aecd
Compare
3 tasks
maxkatz6
force-pushed
the
platform-support-project
branch
from
2b0aecd to
933ee3c
Compare
|
You can test this PR using the following package version. |
maxkatz6
force-pushed
the
platform-support-project
branch
from
933ee3c to
4d866b5
Compare
|
You can test this PR using the following package version. |
grokys
approved these changes
Jan 30, 2022
|
You can test this PR using the following package version. |
DyachenkoA
reviewed
Jan 30, 2022
| #if NETCOREAPP | ||
| IsCoreClr = true, | ||
| #elif NETFRAMEWORK | ||
| IsDotNetFramework = false, |
There was a problem hiding this comment.
Thanks. Will fix it in another pr later.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Removed old shared project and replaces with normal C# project.
Removed code duplication between platform backends.
Breaking changes
Note, new project might be merged into Avalonia project with this PR. Otherwise we can consider Numerge-ing some more dlls.