Nullable annotations for AvaloniaObject/AvaloniaProperty etc. #7078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...to `AvaloniaObject`/`AvaloniaProperty`-related classes and a few other uncontroversial files.
grokys
commented
Dec 6, 2021
| @@ -279,14 +273,14 @@ public abstract class AvaloniaProperty : IEquatable<AvaloniaProperty>, IProperty | |||
| /// <returns>A <see cref="AvaloniaProperty{TValue}"/></returns> | |||
| public static AttachedProperty<TValue> RegisterAttached<TOwner, THost, TValue>( | |||
| string name, | |||
| TValue defaultValue = default(TValue), | |||
| TValue defaultValue = default!, | |||
There was a problem hiding this comment.
This, and the other default! expressions in this file isn't great. Problem is that default is an invalid value if TValue is not nullable and there's not really any way to fix this without breaking changes.
For 11.0 we probably need to supply separate class and struct property registration overloads and only provide a default value for the struct overloads, but this would be a (pretty big) breaking change.
maxkatz6
reviewed
Dec 7, 2021
maxkatz6
reviewed
Dec 7, 2021
13 tasks
maxkatz6
approved these changes
Dec 7, 2021
danwalmsley
pushed a commit
that referenced
this pull request
Dec 7, 2021
* Add nullable annotations... ...to `AvaloniaObject`/`AvaloniaProperty`-related classes and a few other uncontroversial files. * Check for null before first use. * Don't need this check as base class does it. # Conflicts: # src/Avalonia.Styling/Styling/Activators/PropertyEqualsActivator.cs # src/Avalonia.Styling/Styling/PropertyEqualsSelector.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Adds nullable annotations to
AvaloniaObject/AvaloniaProperty-related classes and a few other uncontroversial files.