Start building solution without VS #4661
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rstm-sf
commented
Sep 12, 2020
|
|
||
| return null; | ||
| return RuntimeInformation.IsOSPlatform(OSPlatform.Windows) | ||
| ? RootDirectory / ".tmp" / "dotnet-win" / "sdk" / "3.1.401" / "MSBuild.dll" |
There was a problem hiding this comment.
It would be good to think about not hard-coding the version
There was a problem hiding this comment.
I think you should be able to read global.json file here to find dotnet sdk version.
|
MSBuild from .NET Core can't build Xamarin projects |
|
|
Then it seems to me that it should be postponed |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Start building solution without VS
What is the current behavior?
In order to build a solution using Nuke, we need a pre-installed msbuild from VS
What is the updated/expected behavior with this PR?
Use msbuild from dotnet sdk
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Fixed issues