Fix TextAlignment="DetectFromContent" #17721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the minmal required width.
Gillibald
added
the
backport-candidate-11.2.x
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Dec 10, 2024
maxkatz6
pushed a commit
that referenced
this pull request
Dec 19, 2024
… the minmal required width. (#17721)
maxkatz6
added
backported-11.2.x
and removed
backport-candidate-11.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR reworks the way TextLayout computes its metrics. It now builds a union of all text line bounds and calculates the minimal required width of the TextLayout to render all lines without wrapping or trimming. This is required to horizontally align text constrained by a width greater than the required width.
What is the current behavior?
Currently, the TextLayout takes all the available space and there is no way to know what the minimal required width is so text gets layout bigger than it should be.
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes: #16009