Fixed indented lines in diff flow direction text #17364
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fixed a bug in text layout causing indented lines in text with reverse flow directions due to incorrect positioning of whitespace characters.
What is the current behavior?
No wrap text:
Wrapped text:
What is the updated/expected behavior with this PR?
No wrap text:
Wrapped text:
How was the solution implemented (if it's not obvious)?
For no-wrap text:
The default text for a text-run without content is currently
'a'
, an explicit LTR character. This fix replaces it with a neutral character, enabling the bidi algorithm to consider the direction of preceding RTL characters.For wrapped text:
In wrapped text, the issue occurs because
CoalesceLevels
is called only once before performing text wrapping. After this fix, bidi text will be processed again for each line.Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes #17175