Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the name table optional #17306

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Conversation

Gillibald
Copy link
Contributor

What does the pull request do?

This PR makes it possible to load font files that do not contain a name table

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.3.999-cibuild0052717-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

Copy link
Member

@MrJul MrJul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gillibald Gillibald added this pull request to the merge queue Oct 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 21, 2024
@MrJul MrJul merged commit 63a4eaf into AvaloniaUI:master Oct 21, 2024
10 checks passed
@Gillibald Gillibald deleted the optionalNameTable branch October 21, 2024 13:11
@MrJul MrJul added area-textprocessing enhancement backport-candidate-11.2.x Consider this PR for backporting to 11.2 branch customer-priority Issue reported by a customer with a support agreement. labels Oct 21, 2024
maxkatz6 pushed a commit that referenced this pull request Oct 27, 2024
@maxkatz6 maxkatz6 added backported-11.2.x and removed backport-candidate-11.2.x Consider this PR for backporting to 11.2 branch labels Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-textprocessing backported-11.2.x customer-priority Issue reported by a customer with a support agreement. enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants