You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes an issue that RTL wrapped text calculates an extra line for the control desired size
What is the current behavior?
RTL wrapped text calculates an extra line for control desired size
What is the updated/expected behavior with this PR?
The text will take the required size without the empty line at end
How was the solution implemented (if it's not obvious)?
In-depth investigation reveals that issue occurs because TextEndOfParagraph jumps to start of the text-runs array after bidi-reorder operation, causing the TextLayout.CreateTextLines() to add an unnecessary extra line at end.
The PR ensures that TextEndOfParagraph remains at end of the text-run array. Additionally, it corrects a unit test that was written in relation to this bug.
…rol desired size (#17209)
* Always Return 0 bidi level for TextEndOfLine run
* Fix test unit
* Expand the unit test
---------
Co-authored-by: Benedikt Stebner <[email protected]>
Co-authored-by: Julien Lebosquain <[email protected]>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gillibald
added
the
backport-candidate-11.2.x
maxkatz6
added
backported-11.2.x
and removed
backport-candidate-11.2.x
What does the pull request do?
This PR fixes an issue that RTL wrapped text calculates an extra line for the control desired size
What is the current behavior?
RTL wrapped text calculates an extra line for control desired size
What is the updated/expected behavior with this PR?
The text will take the required size without the empty line at end
How was the solution implemented (if it's not obvious)?
In-depth investigation reveals that issue occurs because
TextEndOfParagraphjumps to start of the text-runs array after bidi-reorder operation, causing theTextLayout.CreateTextLines()to add an unnecessary extra line at end.The PR ensures that
TextEndOfParagraphremains at end of the text-run array. Additionally, it corrects a unit test that was written in relation to this bug.Checklist
Fixed issues
Fixes #16165
Fixes partly #17175