Validate visual parent on attaching to the tree #17049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
added
enhancement
backport-candidate-11.1.x
|
You can test this PR using the following package version. |
MrJul
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Having a real exception message is always better than an NRE.
I don't think we should really lock down anything here, as every system can be abused. (For example all routed events can be raised from anywhere and that can wreak havoc if misused.)
However, we could easily add a comment "Avalonia infrastructure - shouldn't be called by user code", as a warning to some methods.
|
@MrJul it should be doable with existing Avalonia.Analyzer, but the question is which methods to mark. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported, it is possible to bypass "protected" method rules and manually raise AttachedToVisualTree event, without control being attached to the parent. It results in NRE.
While we shouldn't allow manual raise of AttachedToVisualTree event, we also should output more clear validation errors instead of NRE.
cc @jmacato and @MrJul