Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record video for failing win32 integration tests on CI. #16546

Merged
merged 5 commits into from
Aug 3, 2024
Merged

Record video for failing win32 integration tests on CI. #16546

merged 5 commits into from
Aug 3, 2024

Conversation

grokys
Copy link
Member

@grokys grokys commented Jul 31, 2024 •
edited
Loading

What does the pull request do?

This PR causes failing integration tests on Windows CI to upload a video attachment of the failing test. This allows one to more easily debug what's going wrong when a test fails.

When a failure is encountered, it will be visible on the Azure DevOps Tests page, together with the attachment:

image

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0050745-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@grokys grokys force-pushed the feature/record-win32-automation-tests branch from 67dbc32 to 36da5b0 Compare July 31, 2024 09:38
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0050753-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@grokys grokys mentioned this pull request Jul 31, 2024
Merged
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0050843-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@grokys grokys force-pushed the feature/record-win32-automation-tests branch from ce265b7 to c73792c Compare August 2, 2024 07:49
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0050857-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@grokys grokys marked this pull request as ready for review August 2, 2024 08:12
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0050861-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@grokys
Copy link
Member Author

grokys commented Aug 2, 2024

This now seems to work well. I can now see the reason for some of the flaky tests too - somehow something is opening the Windows search box - i assume because the taskbar overlaps the bottom of the window:

image

Looks like we need to increase the screen size, but that should be a separate PR.

Anyway, I've removed the retries so Windows integration tests are going to fail a bit more until we address these issues. This PR should be safe to merge with failing Windows integration tests.

@MrJul MrJul added the area-infrastructure Issues related to CI/tooling infrastructur label Aug 3, 2024
@MrJul MrJul enabled auto-merge August 3, 2024 09:18
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0050891-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0050915-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0050925-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@MrJul MrJul added this pull request to the merge queue Aug 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 3, 2024
@maxkatz6 maxkatz6 merged commit e0e99b3 into master Aug 3, 2024
11 checks passed
@maxkatz6 maxkatz6 deleted the feature/record-win32-automation-tests branch August 3, 2024 21:40
@grokys grokys added the backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch label Aug 5, 2024
@grokys grokys mentioned this pull request Aug 5, 2024
Merged
@maxkatz6 maxkatz6 added the customer-priority Issue reported by a customer with a support agreement. label Aug 12, 2024
maxkatz6 pushed a commit that referenced this pull request Aug 12, 2024
@grokys @MrJul @maxkatz6
Record video for failing win32 integration tests on CI. (#16546)
8796e35 
* Record video for failing win32 integration tests.

* Be more specific when selecting the test dll.

microsoft/vstest#3939

---------

Co-authored-by: Julien Lebosquain <[email protected]>
@maxkatz6 maxkatz6 added backported-11.1.x and removed backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrJul MrJul MrJul approved these changes

Assignees
No one assigned
Labels
area-infrastructure Issues related to CI/tooling infrastructur backported-11.1.x customer-priority Issue reported by a customer with a support agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grokys @avaloniaui-bot @MrJul @maxkatz6