Use culture identifier instead of CultureInfo in NameTable #16310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
|
|
@cla-avalonia agree |
maxkatz6
added
bug
area-trimming-aot
backport-candidate-11.1.x
Gillibald
approved these changes
Jul 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The question was discussed on Telegram channel with @timunie and @Gillibald
What does the pull request do?
Use culture identifier instead of
CultureInfoinNameTableclass.What is the current behavior?
Without the change, applications will build but fail to run the AOT
InvariantGlobalizationflag.What is the updated/expected behavior with this PR?
This is in order to build and run Avalonia apps with the AOT flag
<InvariantGlobalization>true</InvariantGlobalization>.How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues