Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement BindingOperations.GetBindingExpressionBase #16214

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

grokys
Copy link
Member

@grokys grokys commented Jul 3, 2024

What does the pull request do?

Implements BindingOperations.GetBindingExpressionBase and adds basic unit tests.

Fixed issues

Fixes #9525
Fixes #14965

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0049760-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@grokys grokys added the backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch label Jul 3, 2024
@maxkatz6 maxkatz6 added this pull request to the merge queue Jul 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 4, 2024
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0049792-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 enabled auto-merge July 4, 2024 07:41
@maxkatz6 maxkatz6 added this pull request to the merge queue Jul 4, 2024
Merged via the queue into master with commit 640a9dd Jul 4, 2024
11 checks passed
@maxkatz6 maxkatz6 deleted the feature/getbindingexpressionbase branch July 4, 2024 16:51
@grokys grokys removed the backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch label Aug 9, 2024
@WilhelmJP
Copy link

BindingOperations.GetBindingExpressionBase:
Could you please change the BindingExpression class from internal to public so that the properties can be accessed?

@maxkatz6
Copy link
Member

@WilhelmJP it is public in 11.2 builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants