-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build AOT demo project on CI #16108
Build AOT demo project on CI #16108
Conversation
294a013
to
c3df191
Compare
You can test this PR using the following package version. |
You can test this PR using the following package version. |
You can test this PR using the following package version. |
Might not be necessary after #16543 |
Can we run some subset of integration tests with AOT too? e. g. ones that would cover bindings and stuff. |
@kekekeks once [GeneratedComInterface] is merged, I was considering to run full set of integrational tests with AOT. We don't rely on reflection there, it should work well. |
Closing, as we want to focus on integrational tests in AOT mode instead. |
What does the pull request do?
Not sure yet if it's the best way for us to test AOT builds on the CI.
Ideally, we should compile our unit tests with AOT and run them on CI instead.
But for now, building single project with all AOT/trimming errors enabled should be enough.
Continues #15815 (as well as this PR should prevent similar regressions).
What is the current behavior?
If any commit regresses AOT support, including AOT related warnings, nobody might notice until too late.
What is the updated/expected behavior with this PR?
If any commit regresses AOT support, including AOT related warnings, build should fail.
How was the solution implemented (if it's not obvious)?
Re-purposing BindingDemo project as a decent functionality test.