GetDpiForMonitor checks for Windows 8.0, but should check for 8.1 #15734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comparing WindowVersion with Windows8_1 instead of Windows8
|
You can test this PR using the following package version. |
|
|
@cla-avalonia agree |
maxkatz6
added
bug
os-windows
backport-candidate-11.1.x
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
You can test this PR using the following package version. |
maxkatz6
added
the
customer-priority
maxkatz6
changed the title
maxkatz6
added
backported-11.1.x
and removed
backport-candidate-11.1.x
maxkatz6
added a commit
that referenced
this pull request
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fixes #7284
Comparing windows version with Windows8_1 instead of Windows8.
The crash occurs because the Windows Server 2012 version is 6.2.9200, which is greater than 6.2, and comparing it with version 6.2 is incorrect. The function
GetDpiForMonitoris only supported from Windows Server 2012 R2 (version 6.3).What is the current behavior?
The application crashes on Windows Server 2012.
What is the updated/expected behavior with this PR?
Run application on Windows Server 2012 (version 6.2.9200), it should not crash on window creating.
Fixed issues
Fixes #7284