Grid fixes #15516
Merged
Grid fixes #15516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed "System.InvalidOperationException: 'The control GridLinesRenderer already has a visual parent Grid (Name = grid) while trying to add it as a child of Grid (Name = grid).'" when set ShowGridLines = false and resize.
When changing ShowGridLines property GridLinesRenderer is not updating (create/remove/set bounds). Need to call InvalidateArrange -> ArrangeOverride -> EnsureGridLinesRenderer.
|
|
@cla-avalonia agree |
|
You can test this PR using the following package version. |
MrJul
added
the
backport-candidate-11.1.x
maxkatz6
pushed a commit
that referenced
this pull request
May 8, 2024
* Fixed ShowGridLines = false crash Fixed "System.InvalidOperationException: 'The control GridLinesRenderer already has a visual parent Grid (Name = grid) while trying to add it as a child of Grid (Name = grid).'" when set ShowGridLines = false and resize. * Fixed grid lines renderer (fixes ShowGridLines binding) When changing ShowGridLines property GridLinesRenderer is not updating (create/remove/set bounds). Need to call InvalidateArrange -> ArrangeOverride -> EnsureGridLinesRenderer.
maxkatz6
added
backported-11.1.x
and removed
backport-candidate-11.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fixes
Grid.ShowGridLinesusage - crash on false value and resize, not redraw Grid when changed.What is the current behavior?
ShowGridLines= false and resize becauseGridLinesRendererwas added toVisualChildreninstead of remove.ShowGridLinesto any value is not redrawingGridbecauseGridwas invalidating visual but not updatingGridLinesRenderer.GridLinesRendererupdates inArrangeOverride.What is the updated/expected behavior with this PR?
No crash, correct redraw on
ShowGridLineschanged, bindings toShowGridLinesworks.Fixed issues
Fixes #11478