Clear Popup.PlacementTarget in PopupFlyout #15478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
maxkatz6
reviewed
Apr 23, 2024
| @@ -205,7 +205,7 @@ protected virtual bool HideCore(bool canCancel = true) | |||
|
|
|||
| OnClosed(); | |||
|
|
|||
| Target = null; | |||
| Popup.PlacementTarget = Target = null; | |||
There was a problem hiding this comment.
Popup PlacementTarget is already cleaned in latest master https://github.com/AvaloniaUI/Avalonia/pull/15358/files#diff-9326460a9b8237ad899529c7ac3a503a84bc6e43d9ba697eb3fae9f1698015a7L192-R193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Not only Target in PopupFlyoutBase has to be cleared, but also Popup.PlacementTarget. It shouldn't be a problem, because PlacementTarget is set in the very same line as
Target, so I don't think it is necessary to keep this value just like it is not necessary to keep TargetWhat is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
#15465