Fix RemoteServer not starting rendering #15374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
|
Input is definitely handled since the underlying toplevel impl serves our previewer. RemoteServer was intended for remote devtools, but I'm not even sure if those can even be refactored to not use a dedicated window at this point. |
|
While I agree there is a little point of using remote server, we have to keep it somehow usable until we can remove it in 12.0. |
maxkatz6
added
the
backport-candidate-11.1.x
maxkatz6
added a commit
that referenced
this pull request
Apr 20, 2024
maxkatz6
added
backported-11.1.x
and removed
backport-candidate-11.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Remote embedded scenario isn't really one of our advertised features (I only today learned that we even have that).
But since we have it - it should also work at least somehow.
Performance is bad and it never had input implemented, I think?
Fixed issues
Fixes #15336