Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix render mode fallback for Metal #15348

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Conversation

shatyuka
Copy link
Contributor

What does the pull request do?

Fix render mode fallback issue for Metal.

What is the current behavior?

Only OpenGL can be used if RenderingMode has both Metal and OpenGl enabled (default value).

What is the updated/expected behavior with this PR?

Can see the Metal Performance HUD if environment variable MTL_HUD_ENABLED=1.

How was the solution implemented (if it's not obvious)?

Break the loop if the Metal GPU context is successfully initialized.

Checklist

Breaking changes

None

Obsoletions / Deprecations

None

Fixed issues

None

@maxkatz6 maxkatz6 added os-macos backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Apr 13, 2024
Copy link
Member

@maxkatz6 maxkatz6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finding

@maxkatz6 maxkatz6 merged commit e0d4be0 into AvaloniaUI:master Apr 13, 2024
3 of 10 checks passed
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0047254-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

maxkatz6 pushed a commit that referenced this pull request Apr 20, 2024
@maxkatz6 maxkatz6 added backported-11.1.x and removed backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants