Select all input for double-clicks in TextBox with PasswordChar
#14973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xt when the password is not revealed. If the password text is revealed, the pre-existing word-based selection model remains (the closest word to the pointer position is selected.) Related to #14956
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Mar 15, 2024
maxkatz6
added
the
backport-candidate-11.1.x
maxkatz6
added
backported-11.1.x
and removed
backport-candidate-11.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Double-clicks in a
TextBoxwithPasswordCharset are handled by selecting all input, when the passwordis not revealed.
If the password text is revealed, the pre-existing word-based selection model remains (the word closest to the pointer position is selected.)
Related to #14956
What is the current behavior?
Double-clicking currently selects individual words/parts of a cloaked password.
What is the updated/expected behavior with this PR?
If the password is not revealed, then double-clicking selects the entire input.
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes #14956