Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DataGrid): make IDataGridCollectionViewFactory and IDataGridCollectionView, Add DP CollectionView #14744

Merged

Conversation

workgroupengineering
Copy link
Contributor

What does the pull request do?

Currently there is no way for the user collection to implement IDataGridCollectionViewFactory and to provide own implementation of IDataGridCollectionView. In fact, IDataGridCollectionViewFactory is not used at all.

It is needed to avoid the default implementation (DataGridCollectionView), which iterates over the whole collection and doesn't allow a user to implement data virtualization (to avoid keeping large amounts of data in memory).

Added DP CollectionView to allow sorting, grouping the DataGrid even when ItemsSource is not DataGridCollectionView

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

Fixes #13650

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.1.999-cibuild0045391-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.1.999-cibuild0045393-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 merged commit 04f43a5 into AvaloniaUI:master Feb 29, 2024
6 checks passed
@workgroupengineering workgroupengineering deleted the features/Controls/DataGrid branch February 29, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataGrid: IDataGridCollectionViewFactory and IDataGridCollectionView need to be public
3 participants