Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NumericUpDown): Add InnerLeftContent and InnerRightContent #14575

Conversation

workgroupengineering
Copy link
Contributor

@workgroupengineering workgroupengineering commented Feb 10, 2024

Add InnerLeftContent and InnerRightContent to NumericUpDown.

immagine

What does the pull request do?

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

Fixes #14314

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.1.999-cibuild0044757-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@stevemonaco
Copy link
Contributor

Is there some reasoning as to why only InnerContent and not both InnerLeftContent and InnerRightContent as TextBox has? Besides visually crowding the spinner side.

I have a reworked version of NumericUpDown in a local project that uses both. Left side is a label and the right side is a button. Either way, my customization goes further beyond so it wouldn't save me a fork.

@jp2masa
Copy link
Contributor

jp2masa commented Feb 10, 2024

Another common scenario is to add a units label. When the spinner buttons are placed on the right of the text box, this label would be placed between them.

@maxkatz6
Copy link
Member

maxkatz6 commented Feb 11, 2024

Yes, inner content on the same side as buttons is a common scenario. Or even on both sides - icon on left, and units on right.

@workgroupengineering workgroupengineering changed the title feat(NumericUpDown): Add InnerContent feat(NumericUpDown): Add InnerLeftContent and InnerRightContent Feb 11, 2024
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.1.999-cibuild0044816-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added this pull request to the merge queue Feb 14, 2024
Merged via the queue into AvaloniaUI:master with commit 9354650 Feb 14, 2024
5 checks passed
@workgroupengineering workgroupengineering deleted the features/Controls/NumericUpDown/InnerContent branch February 14, 2024 14:47
robloo added a commit to robloo/FluentAvalonia that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants