Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HyperlinkButton #14509

Merged
merged 11 commits into from
Feb 14, 2024
Merged

Add HyperlinkButton #14509

merged 11 commits into from
Feb 14, 2024

Conversation

robloo
Copy link
Contributor

@robloo robloo commented Feb 6, 2024

What does the pull request do?

Adds a new HyperlinkButton control

Depends on: #14320

What is the current behavior?

There is no HyperlinkButton control

What is the updated/expected behavior with this PR?

There is now a HyperlinkButton control with features beyond those in WinUI.

Fluent Theme

image
image

capturegif

Simple Theme

image image

How was the solution implemented (if it's not obvious)?

  1. The UWP/WinUI control was used as a base
  2. Added additional properties discussed in Add HyperlinkButton #7640 to control visited/navigation
  3. Used some ideas and code from the previous attempt Add HyperlinkButton Control #9385

Checklist

Breaking changes

None

Obsoletions / Deprecations

None

Fixed issues

Closes #7640

@robloo
Copy link
Contributor Author

robloo commented Feb 6, 2024

cc @rabbitism

Just keep in mind this is still WIP and isn't complete yet.

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.1.999-cibuild0044481-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@robloo robloo mentioned this pull request Feb 7, 2024
8 tasks
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.1.999-cibuild0044763-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@robloo robloo marked this pull request as ready for review February 10, 2024 16:59
@robloo robloo changed the title WIP: Add HyperlinkButton Add HyperlinkButton Feb 10, 2024
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.1.999-cibuild0044767-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.1.999-cibuild0044825-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.1.999-cibuild0044861-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

Copy link
Member

@maxkatz6 maxkatz6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maxkatz6 maxkatz6 added this pull request to the merge queue Feb 14, 2024
Merged via the queue into AvaloniaUI:master with commit ab71f38 Feb 14, 2024
6 checks passed
@robloo robloo deleted the robloo/hyperlinkbutton branch February 14, 2024 04:16
@HEIC-to-JPEG-Dev
Copy link

Is this now live ? I'm can use it in my code but there is no documented api and it's not in the controls list

@thevortexcloud
Copy link
Contributor

If it's been merged, it is almost certainly out by now. Docs are generally community contributed (especially for a community made control) and people don't always add them when they add a new control. You can possibly submit a PR to add some here:

https://github.com/AvaloniaUI/avalonia-docs

Or kindly ask Robloo if they can do it.

@robloo
Copy link
Contributor Author

robloo commented Nov 29, 2024

Yes, of course this is available in all Nuget packages now. You can see when the PR was merged. It went out in 11.1 I believe.

Keep in mind many developers don't have a lot of time. Especially to update documentation for a very simple control like this.

However, the source code and API are fully documented. I made sure to explain in each property what its for and how to use it. You have full contextual documentation in an IDE when you are using the APIs there. You have access to the source code.

You can also go see the UWP/WinUI documentation if you have general questions on why you would use this type of control.

I will push back a little at comments like this because I know you didn't do any legwork yourself before asking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HyperlinkButton
5 participants