-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HyperlinkButton #14509
Add HyperlinkButton #14509
Conversation
cc @rabbitism Just keep in mind this is still WIP and isn't complete yet. |
You can test this PR using the following package version. |
You can test this PR using the following package version. |
You can test this PR using the following package version. |
You can test this PR using the following package version. |
You can test this PR using the following package version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Is this now live ? I'm can use it in my code but there is no documented api and it's not in the controls list |
If it's been merged, it is almost certainly out by now. Docs are generally community contributed (especially for a community made control) and people don't always add them when they add a new control. You can possibly submit a PR to add some here: https://github.com/AvaloniaUI/avalonia-docs Or kindly ask Robloo if they can do it. |
Yes, of course this is available in all Nuget packages now. You can see when the PR was merged. It went out in 11.1 I believe. Keep in mind many developers don't have a lot of time. Especially to update documentation for a very simple control like this. However, the source code and API are fully documented. I made sure to explain in each property what its for and how to use it. You have full contextual documentation in an IDE when you are using the APIs there. You have access to the source code. You can also go see the UWP/WinUI documentation if you have general questions on why you would use this type of control. I will push back a little at comments like this because I know you didn't do any legwork yourself before asking. |
What does the pull request do?
Adds a new
HyperlinkButton
controlDepends on: #14320
What is the current behavior?
There is no
HyperlinkButton
controlWhat is the updated/expected behavior with this PR?
There is now a
HyperlinkButton
control with features beyond those in WinUI.Fluent Theme
Simple Theme
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
None
Obsoletions / Deprecations
None
Fixed issues
Closes #7640