Set default refresh indicator content in control theme #14443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Feb 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
emmauss
force-pushed
the
fix/refresh_visualizer_indicator_not_set
branch
from
a436f1d to
eba6440
Compare
|
You can test this PR using the following package version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Removes PathIcon style in RefreshVisualizer and explicitly set visualizer indicator instead. Also applies compostion animations to any content set as indicator, instead of path icons.
What is the current behavior?
Currently, there's an issue where styles in a visual in ControlTheme's ControlTemplate aren't applied to children of that visual when the child is added after the template is applied. This pr removes the style relating to the RefreshVisualizer Indicator that sets the path icon data.
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
This is a style breaking change, in behavior only.
Obsoletions / Deprecations
Fixed issues
Fixes #14442