Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AvaloniaVS Intellisense #14397

Merged

Conversation

workgroupengineering
Copy link
Contributor

What does the pull request do?

Restore intellisense with AvloniaVS

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

In PR AvaloniaUI/AvaloniaVS#413 use $(IntermediateOutputPath)/Avalonia/references inteand assemblyname.dll.deps.json, but it does not generate if the project has not any .xaml like XApp target project.

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

Fixes AvaloniaUI/AvaloniaVS#443

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.1.999-cibuild0044143-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6
Copy link
Member

It makes me think, why wouldn't we use "deps" file? That's exactly what previewer uses as well. @Takoooooo @kekekeks

Comment on lines 221 to 222
$(IntermediateOutputPath)/Avalonia/references is using from AvaloniaVS for retrive library refernces.
This target generate $(IntermediateOutputPath)/Avalonia/references for in XApp Template.
Copy link
Contributor

@robloo robloo Feb 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several spelling/grammar issues here. I know these are very hard to see for non-English speakers :) Perhaps you can enable a spell check plug-in though for English projects? LLM AI's are good at this now too.

$(IntermediateOutputPath)/Avalonia/references is used by AvaloniaVS to retrieve library references.
This target generates $(IntermediateOutputPath)/Avalonia/references for use in XApp Template.

I should add I have no idea what "XApp Template" means.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I'm dysgrammatical and sometimes I miss something.

XApp Template -> Cross App platform Template

There are two projects Template see this.

One (app) has a single project entry point, the other (xplat) has an entry point for each platform.

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.1.999-cibuild0044655-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0046658-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0047244-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 merged commit 5a949a3 into AvaloniaUI:master Apr 25, 2024
10 checks passed
@maxkatz6 maxkatz6 added the backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch label Apr 25, 2024
maxkatz6 pushed a commit that referenced this pull request Apr 25, 2024
* fix: AvaloniaVS Intellisense

* fix: Address review
@maxkatz6 maxkatz6 added backported-11.1.x and removed backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Apr 25, 2024
@workgroupengineering workgroupengineering deleted the fix/AvaloniaVS/Itellisense branch April 25, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intellisense does not work
4 participants