Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppleTV support + improvements for iOS backend #14196

Merged
merged 20 commits into from
Jan 21, 2024
Merged

Conversation

maxkatz6
Copy link
Member

@maxkatz6 maxkatz6 commented Jan 14, 2024

What does the pull request do?

  1. Avalonia.iOS backend cleanup, conditionally disabling some features on unsupported platforms (respecting both tvOS and macCatalyst).
  2. Keyboard and remote-control keys/gestures handling.
  3. Initial Metal support for iOS backend was added. It only works well on iOS, as tvOS and macCatalyst require SkiaSharp 3.0. Disabled by default for now, as it's not stable.
  4. Enabled Nullable and various warnings fixes.
  5. Minor changes on top of that, like improving Clipboard support for a bit.

How was the solution implemented (if it's not obvious)?

For the most part, Avalonia.iOS backend is reused, as it is compatible with tvOS.

The same would go with macCatalyst, but: it doesn't support EaGL, and SkiaSharp 2.88 seems to have a broken Metal support for macCatalyst, so no go here. For now.

Fixed issues

Fixed #12523

Improtant

Currently it works well in simulator, but on real device we had a blocker: mono/SkiaSharp#2715

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.1.999-cibuild0043586-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.1.999-cibuild0043783-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.1.999-cibuild0043789-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

Copy link
Member

@kekekeks kekekeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, a few minor comments

@maxkatz6 maxkatz6 merged commit 37d30dc into master Jan 21, 2024
2 of 6 checks passed
@maxkatz6 maxkatz6 deleted the ios-tvos-updates branch January 21, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support tvOS
3 participants