Fix colorAttachment cleaning in the GpuInterop Vulkan demo #13923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
kekekeks
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fixes an incorrect surface cleaning in GpuInterop demo.
What is the current behavior?
There is still red background if change the ClearColorValue for the CmdBeginRenderPass method to white, green or black.
What is the updated/expected behavior with this PR?
Now, an any color can be selected for the background.
How was the solution implemented (if it's not obvious)?
The source of the problem is layout of the Silk.NET.Vulkan.ClearValue structure. Both Color and DepthStencil fields has similar offset equals to 0. And the valid usage of ClearValue structure is define only the Color or the DepthStencil fields, not both an time.
Checklist
Not needed
Breaking changes
None
Obsoletions / Deprecations
None
Fixed issues
None