Fix AVP1012 warnings in Avalonia.Base #13717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR fixes all AVP1012 ("use SetCurrentValue") warnings in Avalonia.Base.
How was the solution implemented (if it's not obvious)?
PolylineSegmentconstructor: ignore the warning, which matches the other constructor.TabItem.Header: I wasn't sure of the change at first, because AVP1012 in this file has been fixed (ead92a6) then reverted (6523320), both in PR #11029. After reading the PR comments, it appears the original fix was a little too broad, hence the revert, but I think theTabItem.Headerone should have been kept.I've added a unit test to confirm that setting the header through a style fails without the changes.
Pinging @maxkatz6 for confirmation