Fix some TextBox property summary docs #13579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fixes errors in the summary docs for two properties.
TextBox.MaxLengthwhich had the definition forMaxLinesTextBox.MaxLineswhich had an incorrect definition based on current functionality and WPFcc @Gillibald
What is the current behavior?
Wrong comments
What is the updated/expected behavior with this PR?
Fixed comments
How was the solution implemented (if it's not obvious)?
Updated comments were sourced from WPF source here: https://github.com/dotnet/wpf/blob/main/src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Controls/TextBox.cs. to avoid potential licensing issues with Microsoft docs. WPF is also MIT licensed. Some additional clarification was needed as well.
Checklist
[ ] Added unit tests (if possible)?[ ] Consider submitting a PR to https://github.com/AvaloniaUI/avalonia-docs with user documentationBreaking changes
None
Obsoletions / Deprecations
None
Related to #13534