Fix - Only add TextSelectionLayer when textpresenter is loaded #13458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmauss
force-pushed
the
fixes/text_selector_layer_overlay_crash
branch
from
2e0435d to
a96af31
Compare
maxkatz6
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This change moves adding of the TextSelectionLayer to OnLoaded, from OnAttachedToVisualTree. This fixes a crash when a textbox is added to the OverlayLayer.
What is the current behavior?
When a TextBox is added to the OverLayer, it forces the TextSelectionLayer to be created and added to the VisualLayerManager, if the layer doesn't currently exist. This addition occurs during the Arrange call of the VLM and in a foreach loop on the current layers, causing a crash.
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues