Make PreventGestureRecognition pointer scope, and not event scope.
#13351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
maxkatz6
approved these changes
Oct 26, 2023
maxkatz6
reviewed
Oct 26, 2023
src/Avalonia.Base/Input/Pointer.cs
Outdated
| /// The previously captured element. This is set when a <see cref="GestureRecognizer"/> captures | ||
| /// the pointer. | ||
| /// </summary> | ||
| internal IInputElement? PreviousCaptured { get; private set; } |
There was a problem hiding this comment.
Need to be careful here to not memory leak anything. Leak test with simulated gestures would be nice as well.
kekekeks
previously requested changes
Oct 26, 2023
| /// element if available. If no gesture is currently started by the pointer, no changes are made. | ||
| /// </summary> | ||
| /// <param name="pointer">The pointer with the captured gesture</param> | ||
| public void CancelCurrentGesture(Pointer pointer) |
There was a problem hiding this comment.
The API usage is unclear. Which element one would call this method on?
There was a problem hiding this comment.
i. e.
<ScrollViewer> <!-- captured here -->
<StackPanel>
<TextBox/> <-- I assume it's the control that would want to cancel the gesture -->
</StackPanel>
</ScrollViewer>On which element should CancelCurrentGesture be called?
There was a problem hiding this comment.
ScrollViewer, in this case.
There was a problem hiding this comment.
Do we need to know that we actually canceled some active gesture?
I could call that at the root level and the method would walk down the visual tree to find a matching control. Do you think this is really needed or should the caller implement this?
emmauss
force-pushed
the
cancel_gesture
branch
from
899fc94 to
3671e82
Compare
emmauss
changed the title
PreventGestureRecognition pointer scope, and not event scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
PreventGestureRecognitionnow prevents gestures from receiving events from the pointer, until pointer is released.What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
This is a change in behaviour
Obsoletions / Deprecations
Fixed issues