Fixed FocusScopes functionality (#10433) #12827
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id raising LostFocusEvent on controls in another focus scope added FocusWithin property that if element or one of its children has IsFocused, it depends on focus scope while IsKeyboardFocusWithin does not added ability to get list of focused elements from multiple focus scopes added ClearFocus method to prevent losing focus from another focus scopes
|
Need a spec + spec review |
|
Overall idea is to complete this spec: #7607 |
|
This PR is not relevant anymore. Because IFocusScope now is not client implementable and after refactorings that allow to return focus to previous control after menu/popup close (in 13409) there is not much point in implementing smth advanced with focus scopes. The only thing that is still not very convenient - when in menu item handler it is needed to do smth with focused element in the main scope, not MenuItem returned by FocusManager. But posting handler to dispatcher so it will be executed after popup closing and returning focus to previous control is a sufficient workaround for such case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pls review thoroughly
What does the pull request do?
See #10433
What is the current behavior?
Menu steals focus from other controls.
What is the updated/expected behavior with this PR?
It works like in WPF, control outside focus scope keeps focused state.
How was the solution implemented (if it's not obvious)?
Breaking changes
It slightly changes :focus-within pseudoclass meaning, which may be a breaking change for someone (I tried to find another name, but for consistency between property and pseudoclass names, renamed old pseudoclass to :keyboard-focus-within).
Also LostFocus event will not be called when focusing something in another focus scope.
Fixed issues
Fixes #10433