fix polygon/polyline load fail points within the template #12651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
|
Thank you! But this PR introduces another bug. Probably, the better fix is to call |
|
I agree, your idea is better. |
Optimization fixed code
…ub.com:a526684540/Avalonia into fix-polygon-polyline-unload-points-in-template
|
You can test this PR using the following package version. |
|
Note: This may fix #11560. That issue was originally noticed in a template. It wasn't tracked down fully since it was faster to work-around the issue with a Path. |
maxkatz6
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
use polygon in button's template,polygon invisible
i want fix polygon/polyline Unable to load points within the template.
What is the current behavior?
What is the updated/expected behavior with this PR?
polygon/polyline can load points within the template.
How was the solution implemented (if it's not obvious)?
Within the polygon constructor, “Points=new Points()”，BindingPriority is LocalValue；
When in the Template，loading points from xaml，BindingPriority is Template，so loading faild，the property points always the "new Points()";
Breaking changes
Obsoletions / Deprecations
Fixed issues