Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing quality parameter #12507

Merged

Conversation

workgroupengineering
Copy link
Contributor

What does the pull request do?

What is the current behavior?

  • quality parameter is ignored in Bitmap.Save

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

Fixes #12493

@workgroupengineering
Copy link
Contributor Author

This PR partial resolve Issue #12493.

the remaining problem is with the save format.
Decode the type based on the file extension, add a parameter that identifies the format.

I can't decide which is the best choice. What do you think in the @avaloniaui-team ?

@kekekeks
Copy link
Member

Neither is the best, it should be handled in the same way as in WPF - BitmapEncoder API, but async. The whole Save method was a stopgap measure that stayed as is for years.

@workgroupengineering
Copy link
Contributor Author

Neither is the best, it should be handled in the same way as in WPF - BitmapEncoder API, but async. The whole Save method was a stopgap measure that stayed as is for years.

They were ideas for not adding breaking change.

What do you think if I mark the save method as obsolete, and in a second PR implement BitmapEncoder.

@workgroupengineering workgroupengineering marked this pull request as ready for review August 16, 2023 12:14
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0038636-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@jmacato
Copy link
Member

jmacato commented Nov 17, 2023

Closing this PR temporarily due to inactivity. Please ping me if this needs to be reopened.

@jmacato jmacato closed this Nov 17, 2023
@Gillibald
Copy link
Contributor

I think we can just merge it

@Gillibald Gillibald reopened this Nov 17, 2023
@maxkatz6 maxkatz6 added this pull request to the merge queue Nov 17, 2023
Merged via the queue into AvaloniaUI:master with commit 65e0431 Nov 17, 2023
@workgroupengineering workgroupengineering deleted the fixes/core/Issue_12493 branch November 17, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quality parameter is ignored in Bitmap.Save with .jpg
6 participants