Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch AutoCompleteBox to using StyledProperty #10712

Merged
merged 3 commits into from
Mar 24, 2023

Conversation

robloo
Copy link
Contributor

@robloo robloo commented Mar 19, 2023

What does the pull request do?

Switches the AutoCompleteBox to using StyledProperty where possible.

What is the current behavior?

AutoCompleteBox has many DirectProperty that cannot be styled.

What is the updated/expected behavior with this PR?

  • Switches the AutoCompleteBox to using StyledProperty where possible
  • SearchText remains a read-only DirectProperty
  • Also fixed a few typos in comments that were easy to search for

How was the solution implemented (if it's not obvious)?

Obvious

Checklist

Breaking changes

Yes, StyledProperty instead of DirectProperty usage but functionality is largely expanded for app developers.

Obsoletions / Deprecations

None

Fixed issues

Part of #9944

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0032054-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 enabled auto-merge March 24, 2023 07:05
@maxkatz6 maxkatz6 added this pull request to the merge queue Mar 24, 2023
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0032204-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

Merged via the queue into AvaloniaUI:master with commit 07afb2f Mar 24, 2023
@robloo robloo deleted the autocompletebox-styledproperty branch March 24, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants