-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internals part #1: platform backends #10336
Conversation
You can test this PR using the following package version. |
Yeah I ran into this: it seems that COM interfaces need to be public to work with the inbuilt COM interop? A pretty strange requirement, and one that I've not actually seen documented anywhere. @jkoritzinsky maybe you might have some insight here? In the longer-term we need to move away from .NET's inbuilt COM support but that's not possible yet. |
It looks like the interfaces are marked |
What does the pull request do?
Hides (almost) all of interface implementations and public API types that should be internal in these assemblies:
Note, win32 automation COM interfaces weren't made internal, as whole automation stops working because of that. I couldn't figure it out quickly, so moved it out of this PR.
Also, it seems to not be possible to disabled resources generation from _UpdateAndroidResgen, so these 1800 lines of public API are still there.
It should be easier to review changes with this commit from API-listing generator branch: aeea42f
Part of #6666