Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch SplitView.IsPaneOpen to a StyledProperty #10138

Merged
merged 11 commits into from
Feb 22, 2023
Merged

Switch SplitView.IsPaneOpen to a StyledProperty #10138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0b51e0d
Remove sender parameter from internal OnEvent methods
robloo Jan 31, 2023
553deb4
Switch SplitView.IsPaneOpen to a StyledProperty
robloo Jan 31, 2023
448fcb4
Merge branch 'master' into SplitView-StyledProperty
robloo Feb 19, 2023
cc1cf20
Separate out SplitView types and move to SplitView directory
robloo Feb 19, 2023
11f0923
Use OnPropertyChanged override method for all SplitView change handling
robloo Feb 19, 2023
1018a77
Switch to routed events in SplitView and support cancellation in open…
robloo Feb 19, 2023
937b07f
Remove SplitViewPaneClosingEventArgs
robloo Feb 19, 2023
afbb04b
Fix eventArgs type in Expander
robloo Feb 19, 2023
fae6f9f
Merge branch 'master' into SplitView-StyledProperty
robloo Feb 19, 2023
d20c6b7
Merge branch 'master' into SplitView-StyledProperty
grokys Feb 22, 2023
d1e7ec3
Merge branch 'master' into SplitView-StyledProperty
maxkatz6 Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Avalonia.Controls/Expander.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ protected virtual void OnCollapsed(RoutedEventArgs eventArgs)
/// <summary>
/// Invoked just before the <see cref="Collapsing"/> event.
/// </summary>
protected virtual void OnCollapsing(RoutedEventArgs eventArgs)
protected virtual void OnCollapsing(CancelRoutedEventArgs eventArgs)
{
RaiseEvent(eventArgs);
}
Expand All @@ -207,7 +207,7 @@ protected virtual void OnExpanded(RoutedEventArgs eventArgs)
/// <summary>
/// Invoked just before the <see cref="Expanding"/> event.
/// </summary>
protected virtual void OnExpanding(RoutedEventArgs eventArgs)
protected virtual void OnExpanding(CancelRoutedEventArgs eventArgs)
{
RaiseEvent(eventArgs);
}
Expand Down
Loading