Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added magnetometer, pressure, temperature, and wind speed information to new message navdata2 #2

Merged
merged 8 commits into from
Aug 1, 2012

Conversation

younata
Copy link
Contributor

@younata younata commented Aug 1, 2012

Added a new message: ardrone/navdata2
This contains navdata information from sensors available only to the ARDrone 2 (though, not sure about wind speed).

I also added checking for subscribers to some of the publishers. navdata, navdata2, image_raw, front/image_raw, and bottom/image_raw have this optimization added.

@ghost ghost assigned mani-monaj Aug 1, 2012
@mani-monaj
Copy link
Member

Thank you very much for this great addition.

As I understood from skimming through the diffs, there is going to be two topics to publish into after this change.

What I suggest is to merge (unify) Navdata2 to Navdata. For ARDrone1 we can just not update Drone2's specific fields.

The fix for not sending data while no one is listening is a good idea.

NAVDATA_OPTION( navdata_magneto_t, navdata_magneto , NAVDATA_MAGNETO_TAG )
NAVDATA_OPTION( navdata_wind_speed_t, navdata_wind_speed , NAVDATA_WIND_TAG )
NAVDATA_OPTION( navdata_kalman_pressure_t,navdata_kalman_pressure , NAVDATA_KALMAN_PRESSURE_TAG )
NAVDATA_OPTION( navdata_pressure_raw_t, navdata_pressure_raw , NAVDATA_PRESSURE_RAW_TAG )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has anything changed here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passed that file through a tab-to-space converter. Nothing of consequence changed.

mani-monaj added a commit that referenced this pull request Aug 1, 2012
[Still Experimental] Added magnetometer, pressure, temperature, and wind speed information to new message navdata2.
@mani-monaj mani-monaj merged commit d0f3502 into AutonomyLab:master Aug 1, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants