Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A: adds 'Dark' mode support on the new Signup form. #99420

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

jkguidaven
Copy link
Contributor

This PR adds 'Dark' mode support on the new Signup form.

Screen.Recording.2025-02-07.at.12.20.11.AM.mov

Depends on #99414
Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/1740

Proposed Changes

  • Add 'Dark' preference CSS rules.

Why are these changes being made?

This is part of the new Signup form project for WC Asia preparation.

Testing Instructions

  • Set your browser preference to 'Dark' mode.
  • Use the A4A live link and go to the /signup/wc-asia page.
  • Test that the form 'Dark' mode styling follows the design

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@jkguidaven jkguidaven self-assigned this Feb 6, 2025
@jkguidaven jkguidaven requested a review from a team February 6, 2025 16:24
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 6, 2025
@jkguidaven jkguidaven marked this pull request as ready for review February 6, 2025 16:25
@matticbot
Copy link
Contributor

matticbot commented Feb 6, 2025

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@andrii-lysenko andrii-lysenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small nitpick regarding Country selector but looks great otherwise

Screenshot 2025-02-06 at 3 25 44 PM

@jkguidaven jkguidaven force-pushed the update/a4a/signup-form-v2-styling branch from 706e9cb to a498ff1 Compare February 7, 2025 09:25
@jkguidaven
Copy link
Contributor Author

A small nitpick regarding Country selector but looks great otherwise

Screenshot 2025-02-06 at 3 25 44 PM

I tried to style it, but it was complicated to override with the CSS rule because it is a styled component (randomized internal class names). We can address this in a separate PR so we don't get blocked.

Base automatically changed from update/a4a/signup-form-v2-styling to trunk February 7, 2025 09:45
@jkguidaven jkguidaven force-pushed the fix/a4a/signup-form-v2-dark-mode branch from ee809d5 to 5c91eeb Compare February 7, 2025 09:46
Comment on lines +19 to +22
| PROPERTY | TYPE | REQUIRED | DEFAULT | DESCRIPTION |
| ------------- | -------- | -------- | ------------------ | ----------------------------------------------- |
| **size** | _number_ | no | `72` | The width and height of the spinner, in pixels. |
| **className** | _string_ | no | `'wordpress-logo'` | The CSS class name applied to the SVG element. |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, lint is complaining now.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/a4a/signup-form-v2-dark-mode on your sandbox.

@jkguidaven jkguidaven merged commit 285be1a into trunk Feb 7, 2025
10 checks passed
@jkguidaven jkguidaven deleted the fix/a4a/signup-form-v2-dark-mode branch February 7, 2025 11:05
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants