-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Admin: introduce package #99348
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
...__core_unstable_copy__/packages/edit-site/src/components/sidebar-navigation-screen/index.tsx
Outdated
Show resolved
Hide resolved
e86eac1
to
9d885b1
Compare
The biggest missing thing here IMO is the documentation.
Some of this would help with reviews too. |
I don’t fully understand the question 😓. Would it simply be a matter of improving the documentation? For example, we could add a section explaining how to discover the package within the codebase and when it should be used. We could also include details about the available public APIs and usage examples to facilitate adoption. If that’s what you mean, and just for your information, we’re still in the development process. These aspects haven’t been addressed yet. The main goal of this draft PR is to evaluate how much sense its implementation makes. |
For the first question, yeah it's a more general question and not specific to this particular package. Like do we need a package reference like there is one for the block editor https://developer.wordpress.org/block-editor/reference-guides/packages/ And how do we raise awareness about the different available packages and possibilities among all engineers to avoid recreating the same things over and over again. I'm sure @tyxla and his team might have thoughts here. The second question is more practical, like I'm not really sure from the PR description what this PR does and the README of the package is empty. I think we should have a README with all the available APIs and how to use them. Like I'm a Woo developer and I want to build a new "section/page" with the proposed framework, how should I do that. |
Oh yes, sure thing 👍 |
c7c8568
to
5d8793c
Compare
@@ -0,0 +1,53 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we decide to go with this "copy from Gutenberg" approach, I'd expect we keep a meticulous documentation, including wha, where, and from which hash/version we copied, plus a thorough changelog of all changes so we keep track of any potential divergence from core in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't agree more. I'd like to edit all commits or create a new branch from scratch to register all changes properly.
This is a hard one IMHO. We can't stop folks from doing the same thing (copying the same components in their local copies), and that's one of the main reasons why we want to be extra careful. If we go that way, let's make sure to do all the due internal developer advocacy so folks are aware this exists, what it offers, and what it exposes from core. We need to make it clear that anyone who wants to use these APIs ideally needs to use this package, and not reinvent their own local version. |
efb42eb
to
feed474
Compare
In case dev folks need a resource that is provided by this package, we should just let them know. Basically, to avoid a new copy. In other words, this package should be the primary source.
This is a somewhat exhausting effort since it relies a lot on personal commitment and responsibility from each developer. This creates a high chance of introducing errors and bad practices simply due to human nature. The good news is that I’ve seen some pretty ugly things lately, so as long as we handle this correctly, I don’t think it can get much worse 😄. Anyway, you never know. That said, clear and effective communication will be key here. |
I'm glad we agree on the potential fragility and change for introducing technical debt here.
That, as well as ownership and responsibility - specifically, following up on what we agreed upon when making those compromises - when the time comes. |
@youknowriad @tyxla, for the sake of the development, I suggest closing this (kinda PoC) PR. We can split and register the tasks in this EPIC issue: #99473 I will add sub-tasks, but please feel free to add/comment as well on whatever you consider appropriate. |
This package provides the necessary resources to implement a modern administrative interface within the WordPress admin.
It includes components for UI construction, a routing system that allows dynamic management and decoration of different layout sections based on active routes, and other resources designed to create a consistent and modular administrative experience.
It is inspired by (if not directly copied from) the core implementation, particularly the Site Editor, replicating its structure and behavior to ensure coherence and compatibility within the existing ecosystem.
Remaining tasks
@wordpress/edit-site
dependencyRelated to #
Proposed Changes
Why are these changes being made?
Testing Instructions
Pre-merge Checklist