Remove Is Reskinned Flag: Untangle domain price of the isReskinned flag

[ddc22]

• Related to: Signup: Deprecate the concept of reskinned flows. #95419

Proposed Changes

• Refactors and removes the need for a reskin flag in domain price component.
• Adds some tests to highlight the various statuses involving the coi

Why are these changes being made?

• Purge the is reskinned flag and also remove related dead/disorganised code.

Testing Instructions

• Check the onboarding flow domain step/start which should remain uneffected
• Check the domains add page /domains/add which should remain uneffected

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-132335

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-132335&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-132335&env=a8c-for-agencies

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• help-center
• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/remove-is-reskinned-from-domains on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~82 bytes removed 📉 [gzipped])

name                  parsed_size           gzip_size
update-design-flow         -624 B  (-0.0%)      -82 B  (-0.0%)
link-in-bio-tld-flow       -624 B  (-0.0%)      -82 B  (-0.0%)
domains                    -624 B  (-0.0%)      -82 B  (-0.0%)
copy-site-flow             -624 B  (-0.1%)      -82 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~82 bytes removed 📉 [gzipped])

name                             parsed_size           gzip_size
async-load-signup-steps-domains       -624 B  (-0.1%)      -82 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[oswian]

For a site on a paid plan (for the test site below oswian70.wordpress.com, the personal plan) the domain price isn't appearing as crossed-out, and is also a slightly larger font size:

PR	Production

[oswian]

Check the onboarding flow domain step/start which should remain uneffected
Check the domains add page /domains/add which should remain uneffected

Tested both scenarios, working as described.

---

/start:

PR	Production

/domains/add:

PR	Production