-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack Settings: Add actions, reducer, selectors and query components for Jumpstart #9868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
Jetpack
[Feature] Site Settings
All other general site settings.
[Status] Needs Review
The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
labels
Dec 7, 2016
55 tasks
LGTM! POST requests work as expected now. |
roccotripaldi
added
[Status] Ready to Merge
and removed
[Status] Needs Review
The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
labels
Dec 13, 2016
…pack Jumpstart status
tyxla
force-pushed
the
add/jetpack-settings-jumpstart-redux
branch
from
December 14, 2016 08:28
15dbe6c
to
8590e06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This PR introduces actions, reducer and selectors for managing Jetpack Jumpstart. Also, a query component for managing network requests for it is being introduced. This PR is part of the Jetpack Module Settings group effort (#9171).
New WP.COM API methods
For interacting with the .com API it introduces 2 methods that are not yet implemented on the API side:
getJetpackJumpstart()
updateJetpackJumpstart()
In order to fully test these methods you can:
To test
QueryJetpackJumpstart
query component and verify it dispatches the proper network requests -<QueryJetpackJumpstart siteId={ 1234 } />
.npm run test-client client/state/jetpack-settings/jumpstart/
/cc @oskosk @roccotripaldi @johnHackworth