Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Settings: Add actions, reducer, selectors and query components for Jumpstart #9868

Merged
merged 10 commits into from
Dec 14, 2016

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Dec 7, 2016

Introduction

This PR introduces actions, reducer and selectors for managing Jetpack Jumpstart. Also, a query component for managing network requests for it is being introduced. This PR is part of the Jetpack Module Settings group effort (#9171).

New WP.COM API methods

For interacting with the .com API it introduces 2 methods that are not yet implemented on the API side:

  • getJetpackJumpstart()
  • updateJetpackJumpstart()

In order to fully test these methods you can:

  • Apply D3588-code on your .com sandbox
  • Apply Add Jumpstart status REST API endpoint jetpack#5813 on your Jetpack site (this PR is needed to enable the endpoint for requesting the current Jumpstart status, and to allow remote requests to the Jetpack REST API).
  • Connect your Jetpack site to your .com sandbox and verify they talk to each other.

To test

  • Checkout this branch
  • Play with the QueryJetpackJumpstart query component and verify it dispatches the proper network requests - <QueryJetpackJumpstart siteId={ 1234 } />.
  • Verify all tests are working: npm run test-client client/state/jetpack-settings/jumpstart/

/cc @oskosk @roccotripaldi @johnHackworth

@tyxla tyxla added Jetpack [Feature] Site Settings All other general site settings. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 7, 2016
@tyxla tyxla added this to the Jetpack Module Settings in Calypso milestone Dec 7, 2016
@tyxla tyxla self-assigned this Dec 7, 2016
@matticbot
Copy link
Contributor

@roccotripaldi
Copy link
Member

LGTM! POST requests work as expected now.

@roccotripaldi roccotripaldi added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 13, 2016
@tyxla tyxla force-pushed the add/jetpack-settings-jumpstart-redux branch from 15dbe6c to 8590e06 Compare December 14, 2016 08:28
@tyxla tyxla merged commit 0132a3c into master Dec 14, 2016
@tyxla tyxla deleted the add/jetpack-settings-jumpstart-redux branch December 14, 2016 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Settings All other general site settings. Jetpack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants