Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purchases: Add notice to PurchasesList after a purchase is canceled #914

Merged
merged 2 commits into from
Dec 1, 2015

Conversation

drewblaisdell
Copy link
Contributor

This adds a success and error notice to PurchasesList, which users will be redirected to after clicking the link in the email they receive when asked to confirm a purchase cancelation.

Requires patch D-573.

Fixes #257.

Testing
You can test the notices by visiting these URLs:

The conditions for redirecting to these URLs are handled by the patch. An unsuccessful cancelation can be triggered by opening the cancelation link from the confirmation email in a browser window that is not logged in to the user that requested the cancelation.

  • QA review
  • Code review

@drewblaisdell drewblaisdell added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Task [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. labels Nov 27, 2015
@drewblaisdell drewblaisdell self-assigned this Nov 27, 2015
@drewblaisdell drewblaisdell added this to the Purchases: v1 milestone Nov 27, 2015
@drewblaisdell drewblaisdell force-pushed the update/canceled-purchase-notice branch from b9b99ba to a50af15 Compare November 27, 2015 23:13
page(
paths.purchases.listNotice(),
controller.sidebar,
controller.purchases.noSitesMessage,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always forget about it, we have sites always loaded when dealing with component loaded by page helper 👍

@gziolo
Copy link
Member

gziolo commented Nov 30, 2015

I left some comments, but don't treat them as blockers. Code in this PR looks good 👍
I didn't look closer at the server patch.

@drewblaisdell drewblaisdell force-pushed the update/canceled-purchase-notice branch from a50af15 to 33124ee Compare November 30, 2015 17:04
@scruffian
Copy link
Member

@drewblaisdell
Copy link
Contributor Author

@scruffian When a purchase is canceled (the cancel-success case), we can't redirect the user to the purchase's page because it no longer exists.

The current implementation of cancel-problem mirrors the old dashboard, but it can probably be changed so that the user goes to the ManagePurchase page for the given purchase, if we expect the purchase to still exist in all of the cases in which there was an issue canceling.

@mikeshelton1503
Copy link
Contributor

If a global notice would provide a better UX than the current implementation (the notice is associated with /purchases/cancel-success, so the notice disappears when the user navigates to a new page, but would return if the user presses back) I'm happy to make the change.

I was unable to test because I never received the email (unrelated to this PR). As I understand it, when you click through from the email a notice is displayed at the top but then disappears when you navigate to another page. Is that correct?

For a successful notice, there is no problem with it disappearing on a new page, however for the error notice, it should persist until dismissed or fixed.

@fabianapsimoes
Copy link
Contributor

@drewblaisdell I did receive the cancellation email, but they still take me to /my-upgrades. Is that expected or did I do something wrong?

I checked the notices in the links you provided, and noticed there's no dismiss button in them.

@fabianapsimoes fabianapsimoes added [Status] Needs Author Reply and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 1, 2015
@scruffian scruffian force-pushed the update/canceled-purchase-notice branch from 33124ee to b5b1720 Compare December 1, 2015 15:58
@scruffian
Copy link
Member

QA 👍

@drewblaisdell drewblaisdell force-pushed the update/canceled-purchase-notice branch from 2308b17 to 2c95386 Compare December 1, 2015 19:18
drewblaisdell added a commit that referenced this pull request Dec 1, 2015
Purchases: Add notice to `PurchasesList` after a purchase is canceled
@drewblaisdell drewblaisdell merged commit 8ede0cd into master Dec 1, 2015
@drewblaisdell drewblaisdell deleted the update/canceled-purchase-notice branch December 1, 2015 19:30
@drewblaisdell
Copy link
Contributor Author

I discussed the issue with the patch with @fabianapsimoes elsewhere and opened an issue for @gziolo's v2 suggestion: #1142

@fabianapsimoes
Copy link
Contributor

I've reported the unaddressed issues in this PR here: #1181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Type] Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants