-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Purchases: Add notice to PurchasesList
after a purchase is canceled
#914
Conversation
b9b99ba
to
a50af15
Compare
page( | ||
paths.purchases.listNotice(), | ||
controller.sidebar, | ||
controller.purchases.noSitesMessage, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always forget about it, we have sites always loaded when dealing with component loaded by page
helper 👍
I left some comments, but don't treat them as blockers. Code in this PR looks good 👍 |
a50af15
to
33124ee
Compare
Are these the right URLs? Should they be more like this? http://calypso.localhost:3000/purchases/:domain/:ID/cancel-problem |
@scruffian When a purchase is canceled (the The current implementation of |
I was unable to test because I never received the email (unrelated to this PR). As I understand it, when you click through from the email a notice is displayed at the top but then disappears when you navigate to another page. Is that correct? For a successful notice, there is no problem with it disappearing on a new page, however for the error notice, it should persist until dismissed or fixed. |
@drewblaisdell I did receive the cancellation email, but they still take me to I checked the notices in the links you provided, and noticed there's no dismiss button in them. |
33124ee
to
b5b1720
Compare
QA 👍 |
2308b17
to
2c95386
Compare
Purchases: Add notice to `PurchasesList` after a purchase is canceled
I discussed the issue with the patch with @fabianapsimoes elsewhere and opened an issue for @gziolo's v2 suggestion: #1142 |
I've reported the unaddressed issues in this PR here: #1181 |
This adds a success and error notice to
PurchasesList
, which users will be redirected to after clicking the link in the email they receive when asked to confirm a purchase cancelation.Requires patch
D-573
.Fixes #257.
Testing
You can test the notices by visiting these URLs:
The conditions for redirecting to these URLs are handled by the patch. An unsuccessful cancelation can be triggered by opening the cancelation link from the confirmation email in a browser window that is not logged in to the user that requested the cancelation.