Reader: launch refreshed full post to everyone #8969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluefuton
added
[Status] Needs Review
|
@bluefuton Does this get rolled out to all languages or everyone that has their language set to English? #8791 (comment) |
All languages, all users :) |
|
so much red. checking this out. |
|
sizes before: sizes after: |
|
Noticed we're not setting the title in the refreshed full post. Will file a new PR to fix. #8984 |
|
@bluefuton pulled a bunch of unneeded code out. could you peek please? |
blowery
force-pushed
the
update/reader/launch-new-full-post
branch
from
6e11103 to
e42859c
Compare
samouri
added
[Status] Ready to Merge
and removed
[Status] Needs Review
|
Even more red! 🚀 |
bisko
pushed a commit
that referenced
this pull request
Nov 16, 2016
* Remove full post A/B test and launch the new full post to everyone * Remove old full post component and update README * remove more code that's no longer needed with the old full post gone * force feed id to a number
jsnajdr
added a commit
that referenced
this pull request
May 2, 2019
Used to be used a long time ago (removed in #8969) in Reader Full Post dialog to call a callback when dialog is unmounted.
jsnajdr
added a commit
that referenced
this pull request
May 7, 2019
* Popover: remove the rootClassName prop Lot of code that passes it to nested components, but no actual usage. * Dialog: remove unused onClosed property Used to be used a long time ago (removed in #8969) in Reader Full Post dialog to call a callback when dialog is unmounted. * Implement RootChild using React portal * Dialog: move initialization of React Modal app element to app boot Makes the component more reusable outside Calypso and avoids trouble in SSR where the DOM is not available. * Dialog: remove RootChild
jsnajdr
added a commit
that referenced
this pull request
May 8, 2019
Used to be used a long time ago (removed in #8969) in Reader Full Post dialog to call a callback when dialog is unmounted.
jsnajdr
added a commit
that referenced
this pull request
Aug 20, 2019
Used to be used a long time ago (removed in #8969) in Reader Full Post dialog to call a callback when dialog is unmounted.
jsnajdr
added a commit
that referenced
this pull request
Aug 22, 2019
Used to be used a long time ago (removed in #8969) in Reader Full Post dialog to call a callback when dialog is unmounted.
jsnajdr
added a commit
that referenced
this pull request
Aug 26, 2019
Used to be used a long time ago (removed in #8969) in Reader Full Post dialog to call a callback when dialog is unmounted.
jsnajdr
added a commit
that referenced
this pull request
Aug 27, 2019
* Merge DialogBase and Dialog into one component * Dialog: remove unused onClosed property Used to be used a long time ago (removed in #8969) in Reader Full Post dialog to call a callback when dialog is unmounted. * Dialog: move initialization of React Modal app element to app boot Makes the component more reusable outside Calypso and avoids trouble in SSR where the DOM is not available. * Dialog: migrate CSS to webpack * Update the LanguagePicker Jest snapshot after DialogBase merge * Dialog: remove unused transition CSS styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Reader full post view is currently being served to 50% of users in an A/B test.
This PR removes the A/B test and serves the new full post view to everyone.
To test
Open your Following stream at http://calypso.localhost:3000/ and open a selection of posts in full post view. Ensure you see the refreshed full post view and everything works as expected: